PIX: Fix instrumentation of libraries; instruction numbering reports#4817
Merged
jeffnn merged 2 commits intomicrosoft:mainfrom Nov 28, 2022
Merged
PIX: Fix instrumentation of libraries; instruction numbering reports#4817jeffnn merged 2 commits intomicrosoft:mainfrom
jeffnn merged 2 commits intomicrosoft:mainfrom
Conversation
|
✅ Build DirectXShaderCompiler 1.0.2297 completed (commit 497603834b by @jeffnn) |
|
✅ Build DirectXShaderCompiler 1.0.2298 completed (commit cc95fc5284 by @jeffnn) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things to fix PIX's operation on lib targets:
-Remove the check for "use_empty" on a function. Lib entry functions have no uses! This was done by centralizing the discovery of interesting (to PIX) functions in a new helper in PixPassHelpers.cpp
-In DxilDebugInstrumentation.cpp, remove the early "return" inside runOnModule. There are more functions left to instrument!
-Add reporting from the virtual register pass that reveals the start and end instruction ordinal for interesting functions. PIX can use these values to disambiguate different functions within a module for e.g. shader debugging output.