Update Linux build and test workflows to use lit#4836
Merged
llvm-beanz merged 4 commits intomicrosoft:mainfrom Dec 2, 2022
Merged
Update Linux build and test workflows to use lit#4836llvm-beanz merged 4 commits intomicrosoft:mainfrom
llvm-beanz merged 4 commits intomicrosoft:mainfrom
Conversation
This change updates the build and test workflows in our azure pipelines and the GitHub action for code coverage data to use lit instead of ctest as the test runner. This adds additional test coverage by running some of the LLVM & Clang tests.
Keenuts
reviewed
Dec 1, 2022
| run: sudo apt install -y ninja-build | ||
| - name: Configure | ||
| run: mkdir build && cd build && cmake -G Ninja -DLLVM_PARALLEL_LINK_JOBS=1 -DLLVM_USE_LINKER=lld -DCMAKE_BUILD_TYPE=Release -DDXC_COVERAGE=On -C ${{github.workspace}}/cmake/caches/PredefinedParams.cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ${{github.workspace}} | ||
| run: mkdir build && cd build && cmake -G Ninja -DLLVM_PARALLEL_LINK_JOBS=1 -DLLVM_USE_LINKER=lld -DCMAKE_BUILD_TYPE=Release -DDXC_USE_LIT=On -DDXC_COVERAGE=On -C ${{github.workspace}}/cmake/caches/PredefinedParams.cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ${{github.workspace}} |
Collaborator
There was a problem hiding this comment.
I see a lot of cd build && ninja ..., they should work with ninja -C build ... no?
Collaborator
Author
There was a problem hiding this comment.
Yea, I could also use cmake -B <> to remove the mkdir && cd there too.
The default Linux linker fails because LLVMAnalysis depends on LLVMDXIL and BFD doesn't cycle libraries.
This just cleans up the pipeline shell commands to avoid unnecissary mkdir and cd invocations. Based on feedback from @Keenuts. Thanks!
DXC disabled support for the LLVM garbage collection intrinsics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the build and test workflows in our azure pipelines and the GitHub action for code coverage data to use lit instead of ctest as the test runner. This adds additional test coverage by running some of the LLVM & Clang tests.