Restore impl of DerivedRecordSize in RDAT#4842
Merged
tex3d merged 1 commit intomicrosoft:mainfrom Dec 5, 2022
Merged
Conversation
This default method implementation is necessary for the base->derived size version mechanism to work. This is only specialized when a base has a derived, and it relies on the newest version to use the default implementation (no specialization). The implementation was removed in commit 8ee6ed1.
|
✅ Build DirectXShaderCompiler 1.0.2340 completed (commit 7dbced52a1 by @tex3d) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This default method implementation is necessary for the base->derived size version mechanism to work. This is only specialized when a base has a derived, and it relies on the newest version to use the default implementation (no specialization).
The implementation was removed in commit 8ee6ed1.