[SPIR-V] Temporarily revert for release#4848
Merged
cassiebeckley merged 1 commit intomicrosoft:mainfrom Dec 6, 2022
Merged
Conversation
Revert "spirv: get field index from SPIR-V type, not AST (microsoft#4806)" This reverts commit 8f279ba. This commit isn't passing some of our internal tests and needs to be reverted in preparation for the next Vulkan SDK release.
cassiebeckley
requested review from
Keenuts and
chrisbieneman
and removed request for
chrisbieneman
cassiebeckley
changed the title
Keenuts
approved these changes
Dec 6, 2022
Keenuts
added a commit
to Keenuts/DirectXShaderCompiler
that referenced
this pull request
Dec 6, 2022
This reverts commit cafbbed.
Collaborator
|
Does the Vulkan SDK release come from the main branch or a release branch? It seems like it would be better if we did this off a release branch and only reverted on the release branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "spirv: get field index from SPIR-V type, not AST (#4806)"
This reverts commit 8f279ba. This commit isn't passing some of our internal tests and needs to be reverted in preparation for the next Vulkan SDK release.