PIX: dxcpdbutils: Don't set default entry name in lib case#4929
Merged
jeffnn merged 3 commits intomicrosoft:mainfrom Jan 12, 2023
Merged
PIX: dxcpdbutils: Don't set default entry name in lib case#4929jeffnn merged 3 commits intomicrosoft:mainfrom
jeffnn merged 3 commits intomicrosoft:mainfrom
Conversation
|
✅ Build DirectXShaderCompiler 1.0.2578 completed (commit 0675af1519 by @jeffnn) |
adam-yang
reviewed
Jan 11, 2023
|
❌ Build DirectXShaderCompiler 1.0.2584 failed (commit ce250795bc by @jeffnn) |
jeffnn
added a commit
to jeffnn/DirectXShaderCompiler
that referenced
this pull request
Jan 13, 2023
…#4929) In the lib case, m_EntryPoint will be non-null but empty, but shouldn't be set anyway. (Also, not clearing m_EntryPoint first can result in an assert in CComPtr that the poiner is non-null, and then the pointer is overwritten, resulting in a small memory leak.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the lib case, m_EntryPoint will be non-null but empty, but shouldn't be set anyway.
(Also, not clearing m_EntryPoint first can result in an assert in CComPtr that the poiner is non-null, and then the pointer is overwritten, resulting in a small memory leak.)