PIX: Educate type system about samplers and resources, base classes#4937
Merged
jeffnn merged 8 commits intomicrosoft:mainfrom Jan 13, 2023
Merged
Conversation
|
✅ Build DirectXShaderCompiler 1.0.2596 completed (commit 4f884c37aa by @jeffnn) |
adam-yang
reviewed
Jan 13, 2023
adam-yang
reviewed
Jan 13, 2023
|
✅ Build DirectXShaderCompiler 1.0.2598 completed (commit 14cc73821b by @jeffnn) |
jeffnn
added a commit
to jeffnn/DirectXShaderCompiler
that referenced
this pull request
Jan 13, 2023
…icrosoft#4937) These fixes were the result of a single shader from a well-known game engine, all of which resulted in mismatched offsets between PIX's offsets-into-fake-allocas and the offsets into aggregates for dbg.value statements. -Base class sizes weren't being added to derived classes -Samplers+Resources weren't being given any size at all -Raygen payloads (referred to by pointer) were triggering an assert Added a new set of tests for the type system to exercise these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixes were the result of a single shader from a well-known game engine, all of which resulted in mismatched offsets between PIX's offsets-into-fake-allocas and the offsets into aggregates for dbg.value statements.
-Base class sizes weren't being added to derived classes
-Samplers+Resources weren't being given any size at all
-Raygen payloads (referred to by pointer) were triggering an assert
Added a new set of tests for the type system to exercise these.