Explicitly use n* version of vsnprintf#4957
Merged
pow2clk merged 1 commit intomicrosoft:mainfrom Jan 20, 2023
Merged
Conversation
Newest clang makes use of older version a warning, which we get as an error
python3kgae
reviewed
Jan 20, 2023
| char msg[512]; | ||
| va_start(Args, pError); | ||
| vsprintf_s(msg, pError, Args); | ||
| vsnprintf_s(msg, _countof(msg), pError, Args); |
Contributor
There was a problem hiding this comment.
So the size will always be 512?
python3kgae
approved these changes
Jan 20, 2023
|
✅ Build DirectXShaderCompiler 1.0.2638 completed (commit 345157571e by @pow2clk) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newest clang makes use of older version a warning, which we get as an error