[Spirv] Fix for validation error VUID-StandaloneSpirv-Flat-04744#5276
Merged
Keenuts merged 8 commits intomicrosoft:mainfrom Jun 9, 2023
Merged
[Spirv] Fix for validation error VUID-StandaloneSpirv-Flat-04744#5276Keenuts merged 8 commits intomicrosoft:mainfrom
Keenuts merged 8 commits intomicrosoft:mainfrom
Conversation
…dings even when unused
generated SPIR-V is invalid: [VUID-StandaloneSpirv-Flat-04744] Fragment OpEntryPoint operand 4 with Input interfaces with integer or float type must have a Flat decoration for Entry Point id 1. %SubgroupLocalInvocationId = OpVariable %_ptr_Input_uint Input
rajivmg
changed the title
|
✅ Build DirectXShaderCompiler 1.0.3319 completed (commit a39c84b89a by @rajivmg) |
|
❌ Build DirectXShaderCompiler 1.0.3320 failed (commit b1046dedb0 by @rajivmg) |
|
✅ Build DirectXShaderCompiler 1.0.3321 completed (commit e3368d2544 by @rajivmg) |
Contributor
Author
|
@llvm-beanz @tex3d @Keenuts @vettoreldaniele @sverrejoh @s-perron // Please review this change.. :) |
s-perron
approved these changes
Jun 9, 2023
Contributor
Author
|
All tests succeeded 2 days ago but this is still showing as not completed. If there is a way can someone please retrigger the pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get this validation error, if the pixel shader use WaveGetLaneIndex() or WaveGetLaneCount() functions.
Cause of the error: https://github.com/KhronosGroup/SPIRV-Tools/blob/59b4febd819977b440692674f6a862d6d17731b5/source/val/validate_decorations.cpp#L876
Fixes #5014