Fix special case with vector swizzle#5281
Merged
s-perron merged 1 commit intomicrosoft:mainfrom Jun 13, 2023
Merged
Conversation
When handling the swizzles in the SPIR-V backen, there is a special case when the final result returns the original vector. It tries to avoid adding the vector shuffle instruction in spir-v. However, that path calls `doExpr` instead of `loadIfGLValue` like the other path. This can sometimes cause a load to be omitted. This is changed so that `loadIfGLValue` is called for both cases. Fixes microsoft#5275
Keenuts
approved these changes
Jun 13, 2023
dnovillo
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handling the swizzles in the SPIR-V backen, there is a special case when
the final result returns the original vector. It tries to avoid adding the
vector shuffle instruction in spir-v. However, that path calls
doExprinsteadof
loadIfGLValuelike the other path. This can sometimes cause a load to beomitted.
This is changed so that
loadIfGLValueis called for both cases.Fixes #5275