This is really a reference (#5473)#5522
Merged
llvm-beanz merged 1 commit intomicrosoft:release-1.7.2308from Aug 10, 2023
Merged
This is really a reference (#5473)#5522llvm-beanz merged 1 commit intomicrosoft:release-1.7.2308from
llvm-beanz merged 1 commit intomicrosoft:release-1.7.2308from
Conversation
This fixes a few cases that were missed when I updated `this` objects to be references. Specifically we were still generating some implicit `this` cases as pointers, and we were not always correctly looking through the reference types. Fixes microsoft#4709
llvm-beanz
added
the
for-release
hekota
approved these changes
Aug 9, 2023
Member
hekota
left a comment
hekota
left a comment
There was a problem hiding this comment.
LGTM! Please add the original commit sha to the description so it makes it into the commit message. Or next time do git cherry-pick -x :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few cases that were missed when I updated
thisobjects to be references. Specifically we were still generating some implicitthiscases as pointers, and we were not always correctly looking through the reference types.Fixes #4709
Cherry-pick of 871fba1