[Diag] Treat entry points as active even if they already have a stage#6022
Merged
bogner merged 3 commits intoNov 16, 2023
Conversation
Created using spr 1.3.5 [skip ci]
Created using spr 1.3.5
llvm-beanz
approved these changes
Nov 15, 2023
Collaborator
|
I already move the isActiveEntry boolean higher in this PR: |
Collaborator
Author
I guess it depends on how close that one is to being ready to merge, and if we did do that I think we'd want to add this test anyways. Personally I'd prefer to merge this targeted fix on it's own |
bob80905
approved these changes
Nov 15, 2023
bogner
added a commit
to bogner/DirectXShaderCompiler
that referenced
this pull request
Nov 15, 2023
If we explicitly annotate an entry point with a shader stage we should treat it as active. Pull Request: microsoft#6022
Created using spr 1.3.5
bogner
changed the base branch from
users/bogner/spr/main.diag-treat-entry-points-as-active-even-if-they-already-have-a-stage
to
main
bogner
deleted the
users/bogner/spr/diag-treat-entry-points-as-active-even-if-they-already-have-a-stage
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we explicitly annotate an entry point with a shader stage we should
treat it as active.