Skip to content

[Validation] Add validation and tests for invalid system values in incompatible node launch type#6108

Merged
bob80905 merged 12 commits intomicrosoft:mainfrom
bob80905:dxil_validation_on_sv_value_node_launch
Jan 24, 2024
Merged

[Validation] Add validation and tests for invalid system values in incompatible node launch type#6108
bob80905 merged 12 commits intomicrosoft:mainfrom
bob80905:dxil_validation_on_sv_value_node_launch

Conversation

@bob80905
Copy link
Collaborator

#5827 first requires validation at the DXIL level. The validation will check for functions that have incompatible node launch types, and intrinsics that represent certain system values.
This PR implements this validation and adds some tests that exercise this validation.
Fixes #6104

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:
darker --check --diff -r 3ef6ca2f94658de919732bae1aa03d69c003bb4b..4dcddfb10f29cb6bb5b8dd8a22a57ffda3abff2a utils/hct/hctdb.py
View the diff from darker here.
--- hctdb.py	2023-12-15 00:36:28.000000 +0000
+++ hctdb.py	2024-01-24 19:25:16.774761 +0000
@@ -7553,11 +7553,11 @@
             "Instr.AtomicIntrinNonUAV", "Non-UAV destination to atomic intrinsic."
         )
         self.add_valrule_msg(
             "Instr.SVConflictingLaunchMode",
             "Input system values are compatible with node shader launch mode.",
-            "Call to DXIL intrinsic %0 (%1) is not allowed in node shader launch type %2"
+            "Call to DXIL intrinsic %0 (%1) is not allowed in node shader launch type %2",
         )
         self.add_valrule("Instr.AtomicConst", "Constant destination to atomic.")
 
         # Work-Graphs
         self.add_valrule(
  • Check this box to apply formatting changes to this branch.

Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bob80905 bob80905 merged commit 02afa57 into microsoft:main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Validation] Validate SV values in combination with node launch types in DXIL

5 participants