[SPIR-V] Mark array reference to aliased var as unaliased#6232
Merged
Conversation
An "aliased" variable is on where the compiler has implicitly added an extra level indirection. So when we access one of these variable, we have to do an extra load. When we do an array access on an aliased variable, we do the extra load before doing the access chain, but we still treat the result of the access chain as if it is an aliased value. This causes an extra load and generates invalid spir-v. The fix is to change `isReferencingNonAliasStructuredOrByteBuffer` so that we do not distinguish between externally and internally visible variable if we see an array subscript. Fixes microsoft#6110
Keenuts
approved these changes
Feb 2, 2024
Co-authored-by: Nathan Gauër <github@keenuts.net>
cassiebeckley
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An "aliased" variable is on where the compiler has implicitly added an
extra level indirection. So when we access one of these variable, we
have to do an extra load.
When we do an array access on an aliased variable, we do the extra load
before doing the access chain, but we still treat the result of the
access chain as if it is an aliased value. This causes an extra load and
generates invalid spir-v.
The fix is to change
isReferencingNonAliasStructuredOrByteBuffersothat we do not distinguish between externally and internally visible
variable if we see an array subscript.
Fixes #6110