[SPIR-V] Add fspv-enable-maximal-reconvergence opt#6248
Merged
Conversation
This option is not enabled by default. When enabled, this option adds the MaximallyReconvergesKHR execution mode to the module, and the associated extension. Signed-off-by: Nathan Gauër <brioche@google.com>
sudonatalie
reviewed
Feb 6, 2024
s-perron
requested changes
Feb 6, 2024
s-perron
reviewed
Feb 7, 2024
sudonatalie
approved these changes
Feb 8, 2024
s-perron
approved these changes
Feb 8, 2024
sudonatalie
added a commit
to sudonatalie/DirectXShaderCompiler
that referenced
this pull request
Mar 19, 2024
The -denorm option allows the shader to select the desired behavior with respect to denormal values. Note that this can't take advantage of the SPIRV-Tools capability trimming pass for the same reasons as described in: microsoft#6248 (comment) Fixes microsoft#6434
Keenuts
pushed a commit
that referenced
this pull request
Mar 25, 2024
The -denorm option allows the shader to select the desired behavior with respect to denormal values. Note that this can't take advantage of the SPIRV-Tools capability trimming pass for the same reasons as described in: #6248 (comment) Fixes #6434
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option is not enabled by default. When enabled, this option adds the MaximallyReconvergesKHR execution mode to the module, and the associated extension.
Related to #6222