Correct metadata load for NodeRecordType for robustness (#6277)#6285
Merged
tex3d merged 1 commit intomicrosoft:release-1.8.2403from Feb 13, 2024
Merged
Conversation
Metadata loading for node record properties assumed fixed positions for values in a (key,value) property list, skipping and ignoring the keys. This was not correct, fragile, and not the intended implementation of the key,value property pattern. There is no functional change, but this makes the loader robust to additional properties instead of crashing or loading the wrong thing. Fixes microsoft#6276 (cherry picked from commit b3be6f2)
pow2clk
approved these changes
Feb 12, 2024
pow2clk
approved these changes
Feb 12, 2024
llvm-beanz
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata loading for node record properties assumed fixed positions for values in a (key,value) property list, skipping and ignoring the keys.
This was not correct, fragile, and not the intended implementation of the key,value property pattern.
There is no functional change, but this makes the loader robust to additional properties instead of crashing or loading the wrong thing.
Fixes #6276
(cherry picked from commit b3be6f2)