[Sema] Only emit warnings on entry point attrs with missing shader attr for libraries (#6284)#6286
Merged
bob80905 merged 1 commit intomicrosoft:release-1.8.2403from Feb 13, 2024
Conversation
…tr for libraries (microsoft#6284) In implementing this PR: microsoft#6243 somehow, the condition to only emit the warning for library shaders was left out. This PR is a follow up on microsoft#6243 to properly restrict the emission of this warning for non-library shaders. This should properly fix microsoft#6100 (cherry picked from commit dbf60d7)
pow2clk
approved these changes
Feb 13, 2024
tex3d
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In implementing this PR:
#6243 somehow, the condition to only emit the warning for library shaders was left out.
This PR is a follow up on #6243 to properly restrict the emission of this warning for non-library shaders.
This should properly fix #6100
(cherry picked from commit dbf60d7)