Add dxilver to tests using -Vd to work around auto-dxilver bug#6369
Merged
tex3d merged 1 commit intomicrosoft:mainfrom Feb 29, 2024
Merged
Add dxilver to tests using -Vd to work around auto-dxilver bug#6369tex3d merged 1 commit intomicrosoft:mainfrom
tex3d merged 1 commit intomicrosoft:mainfrom
Conversation
Issue microsoft#6367 identifies a problem with the auto-dxilver logic based on -T target option in %dxc part when using FileCheckerTest.cpp. This change adds a manual %dxilver 1.8 to two tests that run into this problem, as a workaround.
pow2clk
approved these changes
Feb 29, 2024
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
Appreciate the simpler solution for the sake of the release branch
dmpots
approved these changes
Feb 29, 2024
bob80905
approved these changes
Feb 29, 2024
tex3d
added a commit
to tex3d/DirectXShaderCompiler
that referenced
this pull request
Feb 29, 2024
…soft#6369) Issue microsoft#6367 identifies a problem with the auto-dxilver logic based on -T target option in %dxc part when using FileCheckerTest.cpp. This change adds a manual %dxilver 1.8 to two tests that run into this problem, as a workaround. (cherry picked from commit bbcbb2d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #6367 identifies a problem with the auto-dxilver logic based on -T target option in %dxc part when using FileCheckerTest.cpp.
This change adds a manual %dxilver 1.8 to two tests that run into this problem, as a workaround.