Add mesh launch type for node shaders#6436
Merged
pow2clk merged 12 commits intomicrosoft:release-preview-mesh-nodesfrom Mar 26, 2024
Merged
Add mesh launch type for node shaders#6436pow2clk merged 12 commits intomicrosoft:release-preview-mesh-nodesfrom
pow2clk merged 12 commits intomicrosoft:release-preview-mesh-nodesfrom
Conversation
Adds the ability to specify a mesh node which functions largely like a broadcasting node. This will generate code, metadata, and rdat info for a minimal mesh node. Diagnostics are changed to allow the mesh nodes to be generated. Tests for RDAT and metadata are included. Errors referencing only broadcasting nodes now mention mesh nodes where appropriate. Fixes microsoft#6432
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
python3kgae
reviewed
Mar 19, 2024
tex3d
reviewed
Mar 19, 2024
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Mainly, I think we should:
- Separate test files for mesh node launch from other launch modes.
- Use
lib_6_9target and make sure we don't allow the use of mesh launch in lower shader models inDiagnoseNodeEntry.
added 10 commits
March 20, 2024 23:01
a copy and paste error introduced a failure with the clang-format fixes that this resolves. Split mesh filecheck tests into separate files
node shader validation tests depended heavily on metadata numbers and order. This make them robust so they can work with the 6.9 changes or without
Updates latest shader model to 6.9 and requires it to specify mesh launch types
make them use 6.9 and make them usable with 6.9
deduplication of the 1,9 tuple made the test fail. Using -DAG checks allows the order to work anyway
mesh launch type has value 4
tex3d
reviewed
Mar 25, 2024
damyanp
approved these changes
Mar 26, 2024
Collaborator
Author
|
I don't know why the PR description bot is out to lunch, but the description meets our criteria. I'm merging anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to specify a mesh node which functions largely like a broadcasting node. This will generate code, metadata, and rdat info for a minimal mesh node. Diagnostics are changed to allow the mesh nodes to be generated. Tests for RDAT and metadata are included. Errors referencing only broadcasting nodes now mention mesh nodes where appropriate.
Fixes #6432