Mesh node attribute support#6469
Merged
pow2clk merged 10 commits intomicrosoft:release-preview-mesh-nodesfrom Mar 29, 2024
Merged
Mesh node attribute support#6469pow2clk merged 10 commits intomicrosoft:release-preview-mesh-nodesfrom
pow2clk merged 10 commits intomicrosoft:release-preview-mesh-nodesfrom
Conversation
pow2clk
force-pushed
the
mesh-nodes-attribs
branch
from
6d2e091 to
8f7048f
Compare
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Adds new mesh node attributes NodeMaxInputRecordsPerGraphEntryRecord and OutputTopology including metadata and RDAT generation. Enhances error checking for numthreads consistent with mesh node limits. Adds tests for all mesh node attributes and verifies errors for invalid mesh node attribute usage. Adds minimal support for SV_DispatchGrid annotated struct params in order to enable testing NodeMaxDispatchGrid. Fixes microsoft#6443
pow2clk
force-pushed
the
mesh-nodes-attribs
branch
from
8f7048f to
4143726
Compare
python3kgae
reviewed
Mar 28, 2024
python3kgae
approved these changes
Mar 28, 2024
Contributor
python3kgae
left a comment
python3kgae
left a comment
There was a problem hiding this comment.
Could use REQUIRES: dxil-1-9 instead of %if dxil-1-9.
added 3 commits
March 28, 2024 10:45
using REQUIRED makes the run line less messy
damyanp
approved these changes
Mar 28, 2024
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new mesh node attributes NodeMaxInputRecordsPerGraphEntryRecord and OutputTopology including metadata and RDAT generation. Enhances error checking for numthreads consistent
with mesh node limits. Adds tests for all mesh node attributes and verifies errors for invalid mesh node attribute usage.
Adds minimal support for SV_DispatchGrid annotated struct params in order to enable testing NodeMaxDispatchGrid.
Fixes #6443