Allow derivatives on mesh nodes#6507
Merged
bob80905 merged 5 commits intomicrosoft:release-preview-mesh-nodesfrom Apr 10, 2024
Merged
Allow derivatives on mesh nodes#6507bob80905 merged 5 commits intomicrosoft:release-preview-mesh-nodesfrom
bob80905 merged 5 commits intomicrosoft:release-preview-mesh-nodesfrom
Conversation
python3kgae
approved these changes
Apr 5, 2024
Member
Citation needed :) (Just checking that we're sure about this!) |
tex3d
reviewed
Apr 6, 2024
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
We need test(s) for the DXIL to make sure we don't block derivative intrinsics in validation as well. We also need test(s) checking RDAT, like an adapted version of tools/clang/test/HLSLFileCheck/d3dreflect/rdat_mintarget/sm68_node_deriv.hlsl for SM 6.9 mesh node cases.
Collaborator
Author
|
@damyanp |
tex3d
reviewed
Apr 9, 2024
tex3d
reviewed
Apr 9, 2024
tex3d
reviewed
Apr 9, 2024
tex3d
reviewed
Apr 9, 2024
tex3d
reviewed
Apr 9, 2024
tex3d
reviewed
Apr 9, 2024
tex3d
reviewed
Apr 9, 2024
tex3d
reviewed
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, mesh nodes (that is, node shaders with mesh launch types) would emit diagnostics when they contain a derivative operation. However, mesh nodes should allow derivative operations. This PR adjusts this rule for mesh nodes, so that derivative operations are allowed. An accompanying regression test ensures that diagnostics that would previously be emitted are no longer emitted.
Fixes #6480.