[CoopVec] Check for minimum support set#7457
Merged
alsepkow merged 2 commits intomicrosoft:staging-sm6.9from May 16, 2025
Merged
[CoopVec] Check for minimum support set#7457alsepkow merged 2 commits intomicrosoft:staging-sm6.9from
alsepkow merged 2 commits intomicrosoft:staging-sm6.9from
Conversation
damyanp
approved these changes
May 16, 2025
…xperimentalShaders
jholewinski-nv
force-pushed
the
dev/jholewinski/coopvec-exectests-minset
branch
from
7fade28 to
89985d8
Compare
damyanp
approved these changes
May 16, 2025
alsepkow
reviewed
May 16, 2025
| D3D12_LINEAR_ALGEBRA_DATATYPE_FLOAT_E5M2, /* MatrixInterpretation */ | ||
| D3D12_LINEAR_ALGEBRA_DATATYPE_FLOAT16, /* BiasInterpretation */ | ||
| D3D12_LINEAR_ALGEBRA_DATATYPE_FLOAT16}, /* OutputType */ | ||
| {D3D12_LINEAR_ALGEBRA_DATATYPE_UINT32, /* InputType */ |
Contributor
There was a problem hiding this comment.
I don't think I see this particular set of configs in the linked spec?
Author
There was a problem hiding this comment.
This matches the version in microsoft/hlsl-specs#502.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors the CoopVec test config selection to enforce running the minimum support set. Drivers that do not report all required data formats and interpretations will fail the test.
The handling of
D3D12EnableExperimentalFeaturesis also refactored to apply only to the CoopVec tests, without the use of-p:CooperativeVectorExperimental=*.