Skip to content

[NFC] LongVector ExecTests: Update naming and coding conventions to match llvm coding standards #7519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alsepkow merged 3 commits into from
Jun 6, 2025
Merged

[NFC] LongVector ExecTests: Update naming and coding conventions to match llvm coding standards #7519

alsepkow merged 3 commits into from
Jun 6, 2025

Conversation

@alsepkow
Copy link
Contributor

@alsepkow alsepkow commented Jun 5, 2025

Addresses #7518.

  1. Some functions were factored out of ExecutionTests.cpp in a new header file (HlslExecTestUtils.h) in a previous PR. Update coding conventions for these functions as its now a new file.
  2. Address other misc issues in new code that was added in a previous PR

@alsepkow alsepkow requested a review from bob80905 June 5, 2025 23:43
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@alsepkow alsepkow force-pushed the user/alsepkow/LongVector_Renaming branch from 1d9572d to 4750940 Compare June 5, 2025 23:45
bob80905
bob80905 reviewed Jun 5, 2025
View reviewed changes
inbelic
inbelic reviewed Jun 6, 2025
View reviewed changes
Copy link

@inbelic inbelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the llvm style guide states to have CamelCase for variables. I noted some discrepancies of this, but there could be more.

@bob80905
Copy link
Collaborator

bob80905 commented Jun 6, 2025

Also you might consider adding [NFC] to the PR title

@alsepkow alsepkow changed the title LongVector ExecTests: Update naming and coding conventions to match llvm coding standards [NFC] LongVector ExecTests: Update naming and coding conventions to match llvm coding standards Jun 6, 2025
@alsepkow alsepkow enabled auto-merge (squash) June 6, 2025 01:24
@alsepkow alsepkow merged commit 25f4d37 into microsoft:staging-sm6.9 Jun 6, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Jun 6, 2025
@alsepkow alsepkow deleted the user/alsepkow/LongVector_Renaming branch June 25, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tex3d tex3d tex3d approved these changes

@bob80905 bob80905 bob80905 approved these changes

+1 more reviewer

@inbelic inbelic inbelic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

HLSL Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alsepkow @bob80905 @tex3d @inbelic