Rearrange LongVector Execution Tests infrastructure#7739
Merged
damyanp merged 28 commits intomicrosoft:mainfrom Sep 9, 2025
Merged
Rearrange LongVector Execution Tests infrastructure#7739damyanp merged 28 commits intomicrosoft:mainfrom
damyanp merged 28 commits intomicrosoft:mainfrom
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
alsepkow
reviewed
Sep 8, 2025
Contributor
alsepkow
left a comment
alsepkow
left a comment
There was a problem hiding this comment.
Submitting some comments from initial review
V-FEXrt
approved these changes
Sep 9, 2025
Collaborator
V-FEXrt
left a comment
V-FEXrt
left a comment
There was a problem hiding this comment.
You meantion having NFC/reformatting PR coming so feel free to punt all the comments
Comment on lines
+1443
to
+1445
| auto Config = TestConfig::Create(VerboseLogging); | ||
| if (Config) | ||
| dispatchTest<TrigonometricOpType>(*Config); |
Collaborator
There was a problem hiding this comment.
I don't feel strongly about it but I've seen others suggest something like
Suggested change
| auto Config = TestConfig::Create(VerboseLogging); | |
| if (Config) | |
| dispatchTest<TrigonometricOpType>(*Config); | |
| if (auto Config = TestConfig::Create(VerboseLogging)) | |
| dispatchTest<TrigonometricOpType>(*Config); |
Member
Author
There was a problem hiding this comment.
Oh thanks, this is the sort of thing I'd normally be calling out :)
Collaborator
There was a problem hiding this comment.
Can you make this change for all the instances of auto Config = ... not just this one?
Co-authored-by: Ashley Coleman <ascoleman@microsoft.com>
Co-authored-by: Ashley Coleman <ascoleman@microsoft.com>
Co-authored-by: Ashley Coleman <ascoleman@microsoft.com>
alsepkow
reviewed
Sep 9, 2025
alsepkow
reviewed
Sep 9, 2025
alsepkow
reviewed
Sep 9, 2025
alsepkow
reviewed
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change rearranges the long vector execution test infrastructure to be more static, relying on explicit dispatch tables rather than class hierarchies, variants and std:::functions.
This change tries to avoid moving code around more than it has to. Follow up NFC changes will reorganize this to move more code out of the header.