Add/Update HLK tests for IsSpecialFloat Ops#7743
Conversation
spall
commented
Sep 8, 2025
spall
commented
- update HLK test for 16 bit isinf to specify SM6.9 Closes Add HLK Test for 16 bit isinf for SM6.9 #7600
- update HLK test for 16 bit isnan to specify SM6.9 Closes Add HLK test for 16 bit isnan for SM6.9 #7601
- update HLK test for 16 bit isfinite to specify SM6.9 Closes Add HLK test for 16 bit isfinite for SM6.9 #7602
- add 16 bit HLK test for isnormal which specifies SM6.9 Closes Add HLK test for 16 bit isnormal for SM6.9 #7644
- Move 32 bit HLK test for isnormal to use isnormal instead of isnan Closes Update 32 bit HLK test for IsNormal #7664
| g_buf[GI] = l; | ||
| };</Parameter> | ||
| <Parameter Name="ShaderOp.Target">cs_6_2</Parameter> | ||
| <Parameter Name="ShaderOp.Target">cs_6_9</Parameter> |
There was a problem hiding this comment.
Are we content just upgrading the target SM on these tests? How do we maintain coverage for older shader models or does that even matter?
What do we want to do about 16-bit support in the HLK? Right now, the tests just skip. Do we actually want to enforce anything there? Technically we probably should have HLK requirements for 16-bit support if we truly want to certify via HLK.
There was a problem hiding this comment.
there is no coverage for older shader models; its not supported
…river doesn't support sm6.9 + remove rest of stuff necessary for old removed isnormal test
| CComPtr<IStream> pStream; | ||
| readHlslDataIntoNewStream(L"ShaderOpArith.xml", &pStream, m_support); | ||
|
|
||
| CComPtr<ID3D12Device> pDevice; |
There was a problem hiding this comment.
I'm assuming IsSpecial requires SM6.9? But the 16-bit support for this particular test is an optional feature?
There was a problem hiding this comment.
I just followed how UnaryHalfOpTest treats 16 bit support.
There was a problem hiding this comment.
Yes it requires SM6.9, but with how the tests are currently set up 16 bit support isn't "required".
4 participants
