Make LongVectors tests specified in code and have appropriate HLK properties set#7758
Merged
damyanp merged 33 commits intomicrosoft:mainfrom Sep 16, 2025
Merged
Make LongVectors tests specified in code and have appropriate HLK properties set#7758damyanp merged 33 commits intomicrosoft:mainfrom
damyanp merged 33 commits intomicrosoft:mainfrom
Conversation
damyanp
changed the title
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
alsepkow
reviewed
Sep 16, 2025
alsepkow
reviewed
Sep 16, 2025
alsepkow
reviewed
Sep 16, 2025
| runAndVerify(Config, OpType, Inputs, Expected, ExtraDefines, | ||
| ValidationConfig); | ||
| } | ||
| // Strict Validation - for all types require exact matches. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Strict Validation - for all types require exact matches. | |
| // Strict Validation - for all types that require exact matches. |
alsepkow
reviewed
Sep 16, 2025
alsepkow
reviewed
Sep 16, 2025
| if (Config.LongVectorInputSize) | ||
| InputVectorSizes.push_back(Config.LongVectorInputSize); | ||
| else | ||
| InputVectorSizes = {3, 4, 5, 16, 17, 35, 100, 256, 1024}; |
Contributor
There was a problem hiding this comment.
Suggested change
| InputVectorSizes = {3, 4, 5, 16, 17, 35, 100, 256, 1024}; | |
| // This is the default case. Config.LongVectorInputSize is set via a runtime parameter for local testing. | |
| InputVectorSizes = {3, 4, 5, 16, 17, 35, 100, 256, 1024}; |
Member
Author
There was a problem hiding this comment.
I'm going to try and find a way to express this in the code.
alsepkow
reviewed
Sep 16, 2025
alsepkow
reviewed
Sep 16, 2025
alsepkow
reviewed
Sep 16, 2025
alsepkow
reviewed
Sep 16, 2025
alsepkow
reviewed
Sep 16, 2025
alsepkow
approved these changes
Sep 16, 2025
Contributor
alsepkow
left a comment
alsepkow
left a comment
There was a problem hiding this comment.
LGTM. A few minor comments.
V-FEXrt
approved these changes
Sep 16, 2025
V-FEXrt
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves all of the test definitions from the XML file to the .cpp file and generally moves away from string-matching to statically typed specification of tests, opcodes and test data sets.