Execution Tests: Long Vectors Remove ternary assignment#7775
Merged
alsepkow merged 1 commit intomicrosoft:mainfrom Sep 18, 2025
Merged
Execution Tests: Long Vectors Remove ternary assignment#7775alsepkow merged 1 commit intomicrosoft:mainfrom
alsepkow merged 1 commit intomicrosoft:mainfrom
Conversation
tex3d
approved these changes
Sep 18, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
While I agree that ternary assignment (at least the HLSL 2021+ short-circuiting version) shouldn't require a test, do we have anything for vector select() operation? I see the commit comment says "Its covered via and/or", but vector select is different. Shouldn't that result in an llvm select instruction?
damyanp
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the test cases for ternary assignment. Upon closer inspection I realized that there are no unique DXIL ops or LLVM instructions exercised via ternary assignment (or select for that matter).