Fix running execution tests on x86#7853
Merged
damyanp merged 2 commits intomicrosoft:mainfrom Oct 29, 2025
Merged
Conversation
Member
damyanp
commented
Oct 28, 2025
damyanp
commented
- Updated FindTAEF to use correct names for x86 platforms (WIn32 and X86)
- Updated DownloadWarp to pick appropriate version of WARP for the target platform
- Updated taef.py to not use /inproc. This allows us to run x86 tests on an x64 machine.
* Updated FindTAEF to use correct names for x86 platforms (WIn32 and X86) * Updated DownloadWarp to pick appropriate version of WARP for the target platform * Updated taef.py to not use /inproc. This allows us to run x86 tests on an x64 machine.
Contributor
|
✅ With the latest revision this PR passed the Python code formatter. |
alsepkow
reviewed
Oct 28, 2025
| '/select:', select_filter, | ||
| '/unicodeOutput:false', | ||
| str.format('/outputFolder:{}', self.test_path)] | ||
| cmd = [ |
Contributor
There was a problem hiding this comment.
I'm surprised we had inproc to begin with....It can easily mask real failures, including crashes!
damyanp
added a commit
that referenced
this pull request
Feb 10, 2026
* Updated FindTAEF to use correct names for x86 platforms (WIn32 and X86) * Updated DownloadWarp to pick appropriate version of WARP for the target platform * Updated taef.py to not use /inproc. This allows us to run x86 tests on an x64 machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.