-
Notifications
You must be signed in to change notification settings - Fork 810
Remove hctgettaef.py, fix link to WDK download page #7888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hctgettaef.py downloaded a very old, unsupported version of TAEF. We should be guiding people to download official supported versions, such as the one that you get from the Windows Driver Kit. hctdeploytest.cmd was using hctgettaef.py, but as I can't find any references to it anywhere I'm going to assume it is unused and will remove it rather than try to maintain it.
|
This is quite an aggressive approach to this so I may wait a while before completing it to get some diverse feedback on it! |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Should we consider just deleting these scripts? (by which I mean all the hct{start|build|etc}) They add a bunch of complexity but they aren't strictly needed and I'm not sure maintaining them makes sense. |
We should definitely consider it, but at the moment we have various internal processes that depend on them. Once these dependencies have been removed then, yes! |
tex3d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for cleaning up our process, but it makes me sad that we have to install the whole WDK just to get TAEF dependencies we need. Oh well.
hctgettaef.py downloaded a very old, unsupported version of TAEF. We should be guiding people to download official supported versions, such as the one that you get from the Windows Driver Kit.
hctdeploytest.cmd was using hctgettaef.py, but as I can't find any references to it anywhere I'm going to assume it is unused and will remove it rather than try to maintain it.
Closes #7881