Move double-precision tests to DoublePrecision class#8157
Merged
Conversation
Move 11 double-precision related tests from DxilConf_SM69_Vectorized_Core to DxilConf_SM69_Vectorized_Double as suggested by mmerecki in PR #8134. Tests moved: - CastToFloat64_* (9 variants for different source types) - AsDouble_uint32_t - AsUint_SplitDouble_double These tests now use HLK_TEST_DOUBLE macro to associate them with the Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision specification. Co-authored-by: alsepkow <5620315+alsepkow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move double-precision tests to vectorized double class
Move double-precision tests to DoublePrecision class
Feb 12, 2026
Contributor
|
@copilot We don't need to group the tests like you did. You can leave them in the original location. Just update the macro call. |
Changed HLK_TEST to HLK_TEST_DOUBLE for 11 double-precision tests in their original locations within DxilConf_SM69_Vectorized_Core, rather than moving them to a separate class. Co-authored-by: alsepkow <5620315+alsepkow@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Move double-precision tests to DoublePrecision class
Associate double-precision tests with DoublePrecision HLK specification
Feb 12, 2026
Contributor
|
@copilot I was wrong. You can revert that last commit. |
This reverts commit fee4f4a. Restoring the original approach of moving tests to the Double class. Co-authored-by: alsepkow <5620315+alsepkow@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Associate double-precision tests with DoublePrecision HLK specification
Move double-precision tests to DoublePrecision class
Feb 13, 2026
damyanp
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses mmerecki's comment on PR #8134: several tests operating on double-precision values remained in
DxilConf_SM69_Vectorized_Corebut belong inDxilConf_SM69_Vectorized_Double.Changes
Moved from
DxilConf_SM69_Vectorized_CoretoDxilConf_SM69_Vectorized_Double:CastToFloat64_*(9 variants: HLSLBool_t, HLSLHalf_t, float, uint16_t, uint32_t, uint64_t, int16_t, int32_t, int64_t)AsDouble_uint32_tAsUint_SplitDouble_doubleTechnical change:
DxilConf_SM69_Vectorized_CoreclassDxilConf_SM69_Vectorized_Doubleclass usingHLK_TEST_DOUBLEmacroDevice.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecisionspecificationTest names and OpType template parameters remain unchanged.
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.