Skip to content

[NFC][CMAKE] Fix warning on MacOS build#8166

Merged
Keenuts merged 2 commits intomicrosoft:mainfrom
Keenuts:cmake-fixes-macos
Mar 26, 2026
Merged

[NFC][CMAKE] Fix warning on MacOS build#8166
Keenuts merged 2 commits intomicrosoft:mainfrom
Keenuts:cmake-fixes-macos

Conversation

@Keenuts
Copy link
Copy Markdown
Collaborator

@Keenuts Keenuts commented Feb 18, 2026

This commit fixes 2 warnings showing on when building on MacOS:

  • CMP0135: setting which policy is applied on download freshness check
  • METAL_IRCONVERTER case not matching the FindPackage filename.

Cmake shows a warning because the FindPackage file is using
the camel-case format while the variable prefix is set to the
all-uppercase variant.
Copy link
Copy Markdown
Collaborator

@s-perron s-perron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll abstain. I cannot check this myself, and I don't know the consequences.

@Keenuts Keenuts requested a review from hekota March 24, 2026 09:42
@bogner bogner self-assigned this Mar 25, 2026
@Keenuts Keenuts merged commit 6ea7cf1 into microsoft:main Mar 26, 2026
13 checks passed
@Keenuts
Copy link
Copy Markdown
Collaborator Author

Keenuts commented Mar 26, 2026

Thanks!

@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Mar 26, 2026
@Keenuts Keenuts deleted the cmake-fixes-macos branch March 26, 2026 08:36
@bogner bogner removed their assignment Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants