[SM6.10] Impl Mat Store/Accum ToDescriptor Builtin#8189
Conversation
| // REQUIRES: dxil-1-10 | ||
| // RUN: %dxc -T lib_6_10 %s -verify | ||
|
|
||
| // expected-no-diagnostics |
There was a problem hiding this comment.
are there disallowed stages that should be checked for here? It is always a little odd to me when an error test file expects no errors.
There was a problem hiding this comment.
nope, this test is moreso "ensure all stages allowed"
Its is a weird spot where its the same intent as the error test but all stages are valid
Once all the builtins land, Helena has an open request to merge these into one test with multiple runs. When I do that maybe I could split it into two tests, one for the limited stages case and one for the all stages case
Right, I'm not going to repeat these on each PR, though I think they should be addressed, even if we decide to file a follow-up issue to address in a later PR. |
4 participants
Fixes #7904
Fixes #7906