Emit an error when attempting add a user-defined conversion function#8206
Merged
damyanp merged 9 commits intomicrosoft:mainfrom Apr 14, 2026
Merged
Emit an error when attempting add a user-defined conversion function#8206damyanp merged 9 commits intomicrosoft:mainfrom
damyanp merged 9 commits intomicrosoft:mainfrom
Conversation
…soft#5103) Add err_hlsl_unsupported_conversion_operator diagnostic and check in CheckConversionDeclarator to reject conversion operators in HLSL. Previously these were silently ignored, misleading users into thinking their cast operator overloads were being used. Co-authored-by: damyanp <8118402+damyanp@users.noreply.github.com>
…oad is not allowed' Co-authored-by: damyanp <8118402+damyanp@users.noreply.github.com>
Co-authored-by: damyanp <8118402+damyanp@users.noreply.github.com>
Co-authored-by: damyanp <8118402+damyanp@users.noreply.github.com>
bob80905
approved these changes
Feb 27, 2026
tex3d
reviewed
Mar 11, 2026
Co-authored-by: damyanp <8118402+damyanp@users.noreply.github.com>
…103-tests # Conflicts: # docs/ReleaseNotes.md
tex3d
approved these changes
Apr 14, 2026
|
We actually used CC: @AnastaZIuk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, user-defined conversion functions were silently ignored. This change reports an error if one is defined.
Fixes #5103