[Bug] Add COMPARISON_NONE; fix the error message related to it#8245
Merged
inbelic merged 3 commits intomicrosoft:mainfrom Mar 12, 2026
Merged
[Bug] Add COMPARISON_NONE; fix the error message related to it#8245inbelic merged 3 commits intomicrosoft:mainfrom
inbelic merged 3 commits intomicrosoft:mainfrom
Conversation
ModulePillow
changed the title
Member
|
@inbelic - can you have a look at this PR please? |
inbelic
approved these changes
Mar 10, 2026
| default: | ||
| IFC(Error(ERR_RS_UNEXPECTED_TOKEN, | ||
| "Unexpected texture address mode value: '%s'.", Token.GetStr())); | ||
| "Unexpected comparison function value: '%s'.", Token.GetStr())); |
Collaborator
There was a problem hiding this comment.
It looks like there is the same typo below in ParseBorderColor, we can correct that while here
Contributor
Author
There was a problem hiding this comment.
Noticed, I have fixed it in the new commit
|
|
||
| // Comparison function | ||
| comparisonFunc, | ||
| COMPARISON_NONE, |
Collaborator
There was a problem hiding this comment.
We might also want to add this enum to the COMPARISON_FUNC_TABLE in ShaderOpTest.cpp
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
inbelic
approved these changes
Mar 12, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Awesome, thanks a lot @ModulePillow! I created this issue to propagate the fix forward into clang. If you'd be interested in contributing the fix forward, that'd be great. Just let me know one way or the other. Thanks |
Contributor
Author
|
@inbelic That's fine, I will check the new issue and resolve it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Regarding the sampler descriptions, I found two issues:
Comments