Fix signed/unsigned mismatch in LinAlgTests.cpp#8336
Merged
damyanp merged 2 commits intomicrosoft:mainfrom Apr 3, 2026
Merged
Conversation
Change loop variables from int32_t to size_t to match the NumElements parameter type (size_t), fixing C4018 warnings treated as errors in x86 builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
You can test this locally with the following command:git-clang-format --diff 475e3ccc4bf1d749e88bcc4b6cecba8bd93a81ed e9b6aa2b62432058f4549e817ea07b6caec87562 -- tools/clang/unittests/HLSLExec/LinAlgTests.cppView the diff from clang-format here.diff --git a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
index 96f4aa88..3ab1ac1d 100644
--- a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
+++ b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
@@ -235,7 +235,8 @@ static VariantCompType makeExpected(ComponentType CompType, size_t NumElements,
"Value too large to cast to int32_t");
std::vector<int32_t> Ints(NumElements);
for (size_t I = 0; I < NumElements; I++)
- Ints[I] = static_cast<int32_t>(StartingVal) + static_cast<int32_t>(Increment ? I : 0);
+ Ints[I] = static_cast<int32_t>(StartingVal) +
+ static_cast<int32_t>(Increment ? I : 0);
return Ints;
}
case ComponentType::F16: {
|
V-FEXrt
approved these changes
Apr 3, 2026
tex3d
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change loop variables from int32_t to size_t to match the NumElements parameter type (size_t), fixing C4018 warnings treated as errors in x86 builds.
Assisted-By: Copilot