Skip to content

[PIX] Instrument DebugBreak() calls for PIX#8349

Merged
damyanp merged 4 commits intomicrosoft:mainfrom
henchhinglimbu:pix-debugbreak-hit-instrumentation
Apr 16, 2026
Merged

[PIX] Instrument DebugBreak() calls for PIX#8349
damyanp merged 4 commits intomicrosoft:mainfrom
henchhinglimbu:pix-debugbreak-hit-instrumentation

Conversation

@henchhinglimbu
Copy link
Copy Markdown
Contributor

@henchhinglimbu henchhinglimbu commented Apr 7, 2026 •
edited
Loading

Changes:

  • Add a PIX DXIL pass that replaces DebugBreak() calls with UAV atomic writes so PIX can detect hit locations without halting execution.
  • Wire the new pass into pass registration and the build.
  • Add unit tests and FileCheck coverage for basic, no DebugBreak(), and multiple DebugBreak() cases.

Testing:

  • Built dxcompiler, ClangHLSLTests, and check-all
  • check-all passed locally

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@henchhinglimbu
Copy link
Copy Markdown
Contributor Author

henchhinglimbu commented Apr 8, 2026

@microsoft-github-policy-service agree company="Microsoft"

@henchhinglimbu henchhinglimbu marked this pull request as ready for review April 8, 2026 19:53
jeffnn
jeffnn reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jeffnn jeffnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

damyanp
damyanp reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments / questions...

Comment thread lib/DxilPIXPasses/DxilDebugBreakInstrumentation.cpp Outdated
Comment thread lib/DxilPIXPasses/DxilDebugBreakInstrumentation.cpp Outdated
Comment thread lib/DxilPIXPasses/DxilDebugBreakInstrumentation.cpp Outdated
Comment thread lib/DxilPIXPasses/DxilDebugBreakInstrumentation.cpp
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 15, 2026

Azure Pipelines:
1 pipeline(s) require an authorized user to comment /azp run to run.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 15, 2026

Azure Pipelines:
1 pipeline(s) require an authorized user to comment /azp run to run.

jeffnn
jeffnn approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jeffnn jeffnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMA!

@henchhinglimbu henchhinglimbu requested a review from damyanp April 15, 2026 23:34
@damyanp
Copy link
Copy Markdown
Member

damyanp commented Apr 16, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 16, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@damyanp damyanp enabled auto-merge (squash) April 16, 2026 17:28
@damyanp damyanp merged commit 8066e06 into microsoft:main Apr 16, 2026
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damyanp damyanp damyanp approved these changes

@jeffnn jeffnn jeffnn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

HLSL Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henchhinglimbu @damyanp @jeffnn