[SM6.10][Exec] Fix GetElement test, add transpose to helper#8361
Merged
V-FEXrt merged 6 commits intomicrosoft:mainfrom Apr 10, 2026
Merged
[SM6.10][Exec] Fix GetElement test, add transpose to helper#8361V-FEXrt merged 6 commits intomicrosoft:mainfrom
V-FEXrt merged 6 commits intomicrosoft:mainfrom
Conversation
Contributor
You can test this locally with the following command:git-clang-format --diff e9d74b2e4f20be7b25616f9cf1f02d311357ca45 41ae95cce6fb37b447b332e7ef184dc9be0e4d32 -- tools/clang/unittests/HLSLExec/LinAlgTests.cppView the diff from clang-format here.diff --git a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
index 4146da0c..6eb637cd 100644
--- a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
+++ b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
@@ -246,11 +246,14 @@ static VariantCompType makeExpected(ComponentType CompType, int32_t M,
Floats[Idx] = StartingVal + static_cast<float>(Increment ? Value : 0);
break;
case ComponentType::I32:
- VERIFY_IS_TRUE(StartingVal < static_cast<float>(std::numeric_limits<int32_t>::max()),
- "Value too large to cast to int32_t");
- VERIFY_IS_TRUE(StartingVal > static_cast<float>(std::numeric_limits<int32_t>::min()),
- "Value too small to cast to int32_t");
- Ints[Idx] = static_cast<int32_t>(StartingVal) + static_cast<int32_t>(Increment ? Value : 0);
+ VERIFY_IS_TRUE(StartingVal < static_cast<float>(
+ std::numeric_limits<int32_t>::max()),
+ "Value too large to cast to int32_t");
+ VERIFY_IS_TRUE(StartingVal > static_cast<float>(
+ std::numeric_limits<int32_t>::min()),
+ "Value too small to cast to int32_t");
+ Ints[Idx] = static_cast<int32_t>(StartingVal) +
+ static_cast<int32_t>(Increment ? Value : 0);
break;
case ComponentType::F16: {
// Downcasting is safe here since HLSLHalf_t will clamp if F is too
|
jenatali
requested changes
Apr 9, 2026
bob80905
reviewed
Apr 9, 2026
jenatali
approved these changes
Apr 9, 2026
alsepkow
approved these changes
Apr 9, 2026
tex3d
reviewed
Apr 9, 2026
tex3d
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAJOR_DIMdefinemakeExpected