Skip to content

[SM6.10] Update LinAlg header align parameter#8377

Merged
V-FEXrt merged 2 commits intomicrosoft:mainfrom
V-FEXrt:linalg-fix-align
Apr 16, 2026
Merged

[SM6.10] Update LinAlg header align parameter#8377
V-FEXrt merged 2 commits intomicrosoft:mainfrom
V-FEXrt:linalg-fix-align

Conversation

@V-FEXrt
Copy link
Copy Markdown
Collaborator

@V-FEXrt V-FEXrt commented Apr 15, 2026

microsoft/hlsl-specs#854 updated alignement value in the header. This reflects that spec change

(also deletes some trailing spaces left over in the test files)

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 48975011b060ce8df572420df3717528c7105f74 3de18a68514c2b6a781d4b1c3ca63dffb23f8802 -- tools/clang/lib/Headers/hlsl/dx/linalg.h
View the diff from clang-format here.
diff --git a/tools/clang/lib/Headers/hlsl/dx/linalg.h b/tools/clang/lib/Headers/hlsl/dx/linalg.h
index 209b0b3d..3a939db2 100644
--- a/tools/clang/lib/Headers/hlsl/dx/linalg.h
+++ b/tools/clang/lib/Headers/hlsl/dx/linalg.h
@@ -271,8 +271,7 @@ class Matrix {
   }
 
   static Matrix Load(ByteAddressBuffer Res, uint StartOffset, uint Stride,
-                     MatrixLayoutEnum Layout,
-                     uint Align = 128) {
+                     MatrixLayoutEnum Layout, uint Align = 128) {
     Matrix Result;
     __builtin_LinAlg_MatrixLoadFromDescriptor(Result.__handle, Res, StartOffset,
                                               Stride, Layout, Align);
@@ -280,8 +279,7 @@ class Matrix {
   }
 
   static Matrix Load(RWByteAddressBuffer Res, uint StartOffset, uint Stride,
-                     MatrixLayoutEnum Layout,
-                     uint Align = 128) {
+                     MatrixLayoutEnum Layout, uint Align = 128) {
     Matrix Result;
     __builtin_LinAlg_MatrixLoadFromDescriptor(Result.__handle, Res, StartOffset,
                                               Stride, Layout, Align);
@@ -351,8 +349,7 @@ class Matrix {
   typename hlsl::enable_if<Use == MatrixUse::Accumulator && UseLocal == Use,
                            void>::type
   InterlockedAccumulate(RWByteAddressBuffer Res, uint StartOffset, uint Stride,
-                        MatrixLayoutEnum Layout,
-                        uint Align = 128) {
+                        MatrixLayoutEnum Layout, uint Align = 128) {
     __builtin_LinAlg_MatrixAccumulateToDescriptor(__handle, Res, StartOffset,
                                                   Stride, Layout, Align);
   }
@@ -409,8 +406,7 @@ class Matrix<ComponentTy, M, N, Use, MatrixScope::Thread> {
   template <MatrixLayoutEnum Layout, MatrixUseEnum UseLocal = Use>
   static typename hlsl::enable_if<Use == MatrixUse::A && UseLocal == Use,
                                   Matrix>::type
-  Load(ByteAddressBuffer Res, uint StartOffset, uint Stride,
-       uint Align = 128) {
+  Load(ByteAddressBuffer Res, uint StartOffset, uint Stride, uint Align = 128) {
     Matrix Result;
     __builtin_LinAlg_MatrixLoadFromDescriptor(Result.__handle, Res, StartOffset,
                                               Stride, Layout, Align);
  • Check this box to apply formatting changes to this branch.

Copy link
Copy Markdown
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@V-FEXrt V-FEXrt enabled auto-merge (squash) April 16, 2026 00:40
@V-FEXrt V-FEXrt merged commit 6dee5ce into microsoft:main Apr 16, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants