[SM6.10] Update LinAlg header align parameter#8377
Merged
V-FEXrt merged 2 commits intomicrosoft:mainfrom Apr 16, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
You can test this locally with the following command:git-clang-format --diff 48975011b060ce8df572420df3717528c7105f74 3de18a68514c2b6a781d4b1c3ca63dffb23f8802 -- tools/clang/lib/Headers/hlsl/dx/linalg.hView the diff from clang-format here.diff --git a/tools/clang/lib/Headers/hlsl/dx/linalg.h b/tools/clang/lib/Headers/hlsl/dx/linalg.h
index 209b0b3d..3a939db2 100644
--- a/tools/clang/lib/Headers/hlsl/dx/linalg.h
+++ b/tools/clang/lib/Headers/hlsl/dx/linalg.h
@@ -271,8 +271,7 @@ class Matrix {
}
static Matrix Load(ByteAddressBuffer Res, uint StartOffset, uint Stride,
- MatrixLayoutEnum Layout,
- uint Align = 128) {
+ MatrixLayoutEnum Layout, uint Align = 128) {
Matrix Result;
__builtin_LinAlg_MatrixLoadFromDescriptor(Result.__handle, Res, StartOffset,
Stride, Layout, Align);
@@ -280,8 +279,7 @@ class Matrix {
}
static Matrix Load(RWByteAddressBuffer Res, uint StartOffset, uint Stride,
- MatrixLayoutEnum Layout,
- uint Align = 128) {
+ MatrixLayoutEnum Layout, uint Align = 128) {
Matrix Result;
__builtin_LinAlg_MatrixLoadFromDescriptor(Result.__handle, Res, StartOffset,
Stride, Layout, Align);
@@ -351,8 +349,7 @@ class Matrix {
typename hlsl::enable_if<Use == MatrixUse::Accumulator && UseLocal == Use,
void>::type
InterlockedAccumulate(RWByteAddressBuffer Res, uint StartOffset, uint Stride,
- MatrixLayoutEnum Layout,
- uint Align = 128) {
+ MatrixLayoutEnum Layout, uint Align = 128) {
__builtin_LinAlg_MatrixAccumulateToDescriptor(__handle, Res, StartOffset,
Stride, Layout, Align);
}
@@ -409,8 +406,7 @@ class Matrix<ComponentTy, M, N, Use, MatrixScope::Thread> {
template <MatrixLayoutEnum Layout, MatrixUseEnum UseLocal = Use>
static typename hlsl::enable_if<Use == MatrixUse::A && UseLocal == Use,
Matrix>::type
- Load(ByteAddressBuffer Res, uint StartOffset, uint Stride,
- uint Align = 128) {
+ Load(ByteAddressBuffer Res, uint StartOffset, uint Stride, uint Align = 128) {
Matrix Result;
__builtin_LinAlg_MatrixLoadFromDescriptor(Result.__handle, Res, StartOffset,
Stride, Layout, Align);
|
jenatali
approved these changes
Apr 15, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
alsepkow
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/hlsl-specs#854 updated alignement value in the header. This reflects that spec change
(also deletes some trailing spaces left over in the test files)