Update SPIRV-Tools to remove unused tools/sva directory#8432
Merged
alsepkow merged 3 commits intoMay 11, 2026
Merged
Conversation
s-perron
approved these changes
May 8, 2026
V-FEXrt
approved these changes
May 8, 2026
alsepkow
force-pushed
the
user/alsepkow/update-spirv-tools-cve
branch
from
80531bc to
bc47be3
Compare
The tools/sva directory contained npm dependencies with known CVEs (cross-spawn, braces, minimatch, rollup, etc). SVA was an unmaintained SPIR-V assembler web tool that was removed upstream in KhronosGroup/SPIRV-Tools#6550. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
alsepkow
force-pushed
the
user/alsepkow/update-spirv-tools-cve
branch
from
bc47be3 to
8a977e3
Compare
Contributor
Author
|
Discussed offline to instead take the latest RC candidate from main. #8415 Updating to that. |
tex3d
approved these changes
May 8, 2026
SPIRV-Tools at b2033ea8 requires SPIRV-Headers f88a2d76. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
alsepkow
force-pushed
the
user/alsepkow/update-spirv-tools-cve
branch
from
db67b3b to
ff01b01
Compare
Contributor
|
It looks like we also need to take changes from #8167 due to multi-dim resource array handling changes in this version of SPIR-V tools. I expect that this SPIR-V Tools update only produces better/more-correct output for SPIR-V and is safe to take, but it would still be good to get the opinion of @s-perron to confirm that this change is ok for this release branch, in case we were to roll a point-release update from it. |
…rays The SPIRV-Tools update includes the multi-dimensional resource array linearization pass (LegalizeMultidimArrayPass). This cherry-picks the DXC-side handling from PR microsoft#8167 to properly support the new pass output. Changes by Steven Perron (s-perron). Co-authored-by: Steven Perron <stevenperron@google.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Yes, that should be fine to take. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update SPIR-V tools submodule to commit which removes unused tools/sva directory.