Skip to content

Remove GraphDataType from diskann-providers and relocate to diskann-disk #946

@wuw92

Description

@wuw92

model/graph/traits/graph_data_types.rs: This type should no longer be needed by non-diskann-disk code (and if it is, changing it to a raw T: VectorRepr should be straight-forward).

We should remove this type from diskann-providers and update remaining uses within diskann-providers to just use a vector type, ID type, and associated data type independently as needed.

The problem with using this large list of associated types to instantiate generic functions that only use a portion is that it can lead to redundant monomorphizations, and makes uses less clear on whether all associated data types are used or not.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions