Skip to content

[parameter enhancement] params pass in reference instead of const string#297

Merged
gopalrs merged 2 commits intomicrosoft:mainfrom
jinwei14:parametersImprove
Apr 4, 2023
Merged

[parameter enhancement] params pass in reference instead of const string#297
gopalrs merged 2 commits intomicrosoft:mainfrom
jinwei14:parametersImprove

Conversation

@jinwei14
Copy link
Copy Markdown
Contributor

@jinwei14 jinwei14 commented Apr 3, 2023

  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues/PRs

What does this implement/fix? Briefly explain your changes.

Any other comments?

@jinwei14 jinwei14 changed the title generate_quantized_data pass in referemce instead of const string params pass in reference instead of const string Apr 4, 2023
@jinwei14 jinwei14 changed the title params pass in reference instead of const string [parameter enhancement] params pass in reference instead of const string Apr 4, 2023
@gopalrs gopalrs merged commit ed59551 into microsoft:main Apr 4, 2023
Danbaiwq pushed a commit to Danbaiwq/DiskANN that referenced this pull request Sep 10, 2025
[parameter enhancement] params pass in reference instead of const string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants