fix(ci): use variable reference for AllNodesClientId in e2e test stage#1683
Merged
zanejohnson-azure merged 1 commit intoMay 14, 2026
Merged
Conversation
The ci-logs-dev-aks-all-nodes E2E test stage was passing the literal string 'AllNodesClientId' as azureClientId instead of the variable reference $(AllNodesClientId). This caused the test pod's workload identity to be configured with a non-GUID client ID, resulting in ManagedIdentityCredential failing with 'Identity not found' when querying Log Analytics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rashmichandrashekar
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ci-logs-dev-aks-all-nodesE2E test was failing onKubePodInventory(and other log-query tests) with:Root cause
In
.pipelines/azure_pipeline_mergedbranches.yaml, the E2E test stage for theci-logs-dev-aks-all-nodescluster was passing the literal string'AllNodesClientId'asazureClientIdinstead of the variable reference$(AllNodesClientId).Every other cluster stage in the file uses the
$(...)form (e.g.$(AksWorkLoadIdentityClientId),$(WcusFipsClientId),$(NetworkFlowLogsClientId)), which substitutes the actual workload-identity client GUID from the variable group. The literal string was being plumbed all the way into the test pod asAZURE_CLIENT_ID, so no managed identity matched and token acquisition failed.Fix
Note
This assumes a variable named
AllNodesClientIdexists in the variable group bound to this pipeline (containing the workload-identity client ID GUID for theci-logs-dev-aks-all-nodescluster). If it doesn't yet, it needs to be added there alongside the other*ClientIdvariables — otherwise the substitution will be empty and the test will still fail with the same auth error.