fixed issue related to modswitch and raw type#9
Merged
olsaarik merged 1 commit intomicrosoft:contribfrom Apr 23, 2021
Merged
Conversation
Contributor
|
I ran the tests we have with no failures. Thanks for fixing this! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue when a raw type node is used at multiple levels. Modswitch nodes are added for raw type node if it is used at multiple nodes. However, Modswitch doesn't make sense for Raw type of data, and it is not supported by the backend. To fix this issue, I have modified the Modswitch pass to avoid nodes of Raw type.