UI vertical-slice migration with hexagonal Common/ ports#519
Merged
Conversation
c8ce6d0 to
7136403
Compare
1456555 to
3c091f2
Compare
…blePane/LogTabBar UI
…verter, FolderPickerHelper
3c091f2 to
f7c9945
Compare
NikTilton
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganizes the EventLogExpert.UI project into a vertical-slice architecture with hexagonal Common/ ports for cross-cutting infrastructure. Builds on top of the eventing-restructure branch (#518).
Highlights
Hexagonal Common/ ports (R2-R8, R30-R33):
IInlineAlertHostBroker)Common/IPreferencesProvider,Versioning,AppTitle,IMainThreadService,IWindowsIdentityProvider,LoggingMiddleware,DisplayExtensionsall relocated toCommon/<Domain>/slicesVertical slice promotion (R9-R20):
StatusBar, DebugLog, Banner, Modal, Alerts, Settings, Menu, Database, Update (incl. Deployment + ReleaseNotes), LogTable (was EventTable), EventLog, Filter (incl. FilterCache, FilterGroup, FilterPane).
Renames at the type/file level:
EventTable->LogTableslice +LogViewrecord +LogTablePane/LogTabBarcomponentsCopyType->EventCopyFormatModalAlertDialogService->AlertDialogServiceGitReleaseModel->GitHubReleaseSavedFilter/SavedFilterGroup/FilterDraft/DateFilterclarificationsFilterDraft.FromFilterModel->FromSavedFilterTyped ID records (replaces raw
Guidon internal IDs):EventLogId(existing pattern)BannerId(Banner slice)UpgradeBatchId(Database.Upgrade event flow)StatusActivityId(StatusBar loading-tracker)Internalizations / surface tightening:
SavedFilterJsonConverter-> internalFolderPickerHelper-> internalGitHubReleaseNormalizer(already internal) relocated next to its sole consumer (Update/)Methodology
Atomic commit-per-slice with the eventing-PR conventions:
dotnet format whitespace --verify-no-changes,dotnet format style --diagnostics IDE0005 IDE0065,dotnet test, ReSharper cleanupTest baseline (locked)
1610 unit + 235 integration. All gates green at HEAD.
Notes
LogTablerename brings the EventTable slice into the consistent UI naming system (*Layout/*Pane/*Bar/*Host).EventLogExpert.Componentsis a separate assembly without IVT to UI; some types remainpublicbecause Components consumes them. Filter-internal candidates that depend onEditableFilterRowBaseare tracked for the follow-up filter-rework task.