Pin .NET SDK floor to 10.0.204 via global.json#534
Merged
Conversation
NikTilton
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SFI alert flagged that EventLogExpert ships a self-contained .NET application with an unpinned runtime version. The runtime baked into the published MSIX / EXE is whatever the active .NET SDK provides, and the repo had no
global.jsonto enforce a secure minimum (the only build pipeline floated SDK viadotnet-version: 10.x). Alert recommendation: pin SDK floor to ≥ 10.0.204.What
global.jsonat repo root pinning SDK floor to10.0.204withrollForward: latestFeature. This enforces the SFI floor on every build (local dev, PR CI, downstream release pipeline) while allowing newer 10.0.x patches without manual bumps and without silently jumping to .NET 11..github/workflows/PullRequest.ymlto source the SDK fromglobal.json(global-json-file: global.json) instead of the floatingdotnet-version: 10.x.The downstream Azure DevOps release pipeline will be updated in a separate PR to consume the same
global.json.Verification
dotnet --infoconfirmsglobal.jsonis detected at repo root and resolves to SDK10.0.300(satisfies the 10.0.204 floor vialatestFeature).dotnet build EventLogExpert.slnx -c Releasesucceeds (41s, 0 warnings, 0 errors).