Introduce IModalCoordinator with strongly-typed ModalId and async inline-alert disposal

[jschick04]

First in the sequential SoC refactor split (squashed to a single PR for shipping; split for easier review).

Scope

• Folds the deleted IInlineAlertHostBroker into the new IModalCoordinator (one front-door for modal lifecycle + inline-alert host registry, one shared source of truth via IModalService.StateChanged).
• Introduces strongly-typed ModalId (readonly record struct ModalId(long Value) with ModalId.None sentinel) to match the established codebase pattern (FilterId, FilterGroupId, BannerId, etc.). Internal long _idCounter in ModalService is preserved; the wrap happens at the public surface.
• Converts inline-alert CancellationTokenRegistration disposal to await DisposeAsync() where the enclosing context is genuinely async:
  • ShowInlineAlertAsync is now async; await prior.CancellationRegistration.DisposeAsync() replaces sync Dispose().
  • DisposeAsyncCore awaits DisposeAsync() on the pending registration.
  • HandleInlineAlertResolvedAsync is now genuinely async (no more fire-and-forget _ = InvokeAsync(StateHasChanged)); inlines the lock-and-clear path so DisposeAsync() can be awaited.
  • TryClearInlineAlertFromCallback stays sync — it's only called from the cancellationToken.Register Action delegate where the BCL contract forces sync.
• Critical concurrency fix in ModalService: reorder Complete / CancelActive / Show so state-clear under lock → StateChanged?.Invoke() → tcs/cancel-delegate ALL fire outside the lock. Without the reorder, an awaiter resuming on a RunContinuationsAsynchronously continuation could observe stale state via subscribers (e.g., the new IModalCoordinator mirror).

Tests

• 13 new ModalCoordinatorTests covering the coordinator contract (state mirror, host register/unregister, stale-id lazy invalidation, dispose unhooks, push preempts prior).
• 3 new ModalServiceCompletionOrderingTests verifying StateChanged fires before awaiter resumes on Complete/CancelActive/Show preempt paths.
• Deleted: InlineAlertHostBrokerTests (broker folded into coordinator).
• Existing tests updated to ModalId.
• Build: 0 warnings, 0 errors.
• Test run: 892 Runtime + 150 UI = 1,042 passing.

Files

19 files changed (+652 / -349):

New:

• src/EventLogExpert.Runtime/Modal/IModalCoordinator.cs
• src/EventLogExpert.Runtime/Modal/ModalCoordinator.cs
• src/EventLogExpert.Runtime/Modal/ModalId.cs
• src/EventLogExpert.Runtime/Modal/ModalSession.cs
• tests/Unit/EventLogExpert.Runtime.Tests/Modal/ModalCoordinatorTests.cs
• tests/Unit/EventLogExpert.Runtime.Tests/Modal/ModalServiceCompletionOrderingTests.cs

Deleted:

• src/EventLogExpert.Runtime/Alerts/IInlineAlertHostBroker.cs
• src/EventLogExpert.Runtime/Alerts/InlineAlertHostBroker.cs
• tests/Unit/EventLogExpert.Runtime.Tests/Alerts/InlineAlertHostBrokerTests.cs

Modified:

• src/EventLogExpert.Runtime/Modal/IModalService.cs (ActiveModalId/Complete take ModalId)
• src/EventLogExpert.Runtime/Modal/ModalService.cs (concurrency reorder + ModalId public surface)
• src/EventLogExpert.UI/Modal/ModalBase.cs (async refactor + ModalId)
• src/EventLogExpert.Runtime/Alerts/AlertDialogService.cs (accepts IModalCoordinator; host is null flow)
• src/EventLogExpert.Runtime/DependencyInjection/RuntimeServiceCollectionExtensions.cs
• src/EventLogExpert/MauiProgram.cs (factory resolves IModalCoordinator)
• 4 test files updated for ModalId

Notes

• This is PR 1+2 of the broader 9-PR SoC refactor plan (Slot 1's roadmap). Future PRs handle OnRequestCloseAsync veto pipeline, ModalScope.Critical, typed launchers, DatabaseRecoveryDialog migration, IBannerService split, BannerHost decomposition, IMenuActionService shrink, and re-applying the banner Banner: chevron nav not working and Attention 'Open Settings' shows while Settings is already open #526 stash (which becomes ~250 LOC once the workaround state goes away).

[Copilot]

Pull request overview

This PR introduces a new IModalCoordinator as the single coordination surface for modal lifecycle + inline-alert host registration, while also adding a strongly-typed ModalId and adjusting modal/inline-alert completion ordering to avoid stale state observations by subscribers.

Changes:

• Added IModalCoordinator/ModalCoordinator + ModalSession to mirror IModalService state and own inline-alert host registration.
• Introduced ModalId (with ModalId.None) and updated IModalService/call sites/tests to use it instead of long.
• Refactored ModalBase inline-alert handling to use async disposal (DisposeAsync) and reordered ModalService completion/cancel/show paths to invoke StateChanged before resuming awaiters.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/EventLogExpert.Runtime/Modal/IModalCoordinator.cs	New coordinator contract for modal lifecycle + inline-alert host registry.
src/EventLogExpert.Runtime/Modal/ModalCoordinator.cs	Implements coordinator mirror + inline-alert host registry.
src/EventLogExpert.Runtime/Modal/ModalId.cs	Adds strongly-typed modal identifier with None sentinel.
src/EventLogExpert.Runtime/Modal/ModalSession.cs	Adds active-modal snapshot type exposed by the coordinator.
tests/Unit/EventLogExpert.Runtime.Tests/Modal/ModalCoordinatorTests.cs	Adds coordinator behavior tests (mirror, registry, disposal).
tests/Unit/EventLogExpert.Runtime.Tests/Modal/ModalServiceCompletionOrderingTests.cs	Adds ordering tests for StateChanged vs awaiter resumption.
src/EventLogExpert.Runtime/Alerts/IInlineAlertHostBroker.cs	Deleted (responsibility moved into IModalCoordinator).
src/EventLogExpert.Runtime/Alerts/InlineAlertHostBroker.cs	Deleted (responsibility moved into ModalCoordinator).
tests/Unit/EventLogExpert.Runtime.Tests/Alerts/InlineAlertHostBrokerTests.cs	Deleted (replaced by coordinator tests).
src/EventLogExpert.Runtime/Modal/IModalService.cs	Updates surface to use ModalId for ActiveModalId/Complete.
src/EventLogExpert.Runtime/Modal/ModalService.cs	Wraps id as ModalId and reorders completion/cancel/show for correct notification sequencing.
src/EventLogExpert.UI/Modal/ModalBase.cs	Uses IModalCoordinator, ModalId, and async inline-alert registration disposal.
src/EventLogExpert.Runtime/Alerts/AlertDialogService.cs	Routes inline alerts via IModalCoordinator instead of broker.
src/EventLogExpert.Runtime/DependencyInjection/RuntimeServiceCollectionExtensions.cs	Registers IModalCoordinator and removes broker registration.
src/EventLogExpert/MauiProgram.cs	Resolves IModalCoordinator for AlertDialogService factory wiring.
tests/Unit/EventLogExpert.UI.Tests/DebugLog/DebugLogModalTests.cs	Updates test DI setup to provide IModalCoordinator and ModalId.
tests/Unit/EventLogExpert.Runtime.Tests/Modal/ModalServiceTests.cs	Updates assertions to use ModalId.None.
tests/Unit/EventLogExpert.Runtime.Tests/DependencyInjection/RuntimeServiceCollectionExtensionsTests.cs	Updates DI registration expectations to IModalCoordinator.
tests/Unit/EventLogExpert.Runtime.Tests/Alerts/AlertDialogServiceTests.cs	Updates routing tests to use IModalCoordinator.TryGetInlineAlertHost.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.