PR 10 Commits E+F: Remove redesign + multi-select + reusable Checkbox component (closes #525)#556
Closed
jschick04 wants to merge 5 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the prior slide-reveal/aria-disabled Remove flow on the Settings → Manage Databases tab with an always-visible per-row trash button plus a row-level checkbox for multi-select, a sticky bulk action strip, and an inline confirmation modal that supports cancel-then-remove for in-flight upgrades. Also extracts the per-row checkbox into a reusable Checkbox input component mirroring the Toggle convention.
Changes:
- New
Checkboxinput (visually-hidden native<input type="checkbox">+ custom icon, sharingInputComponent<bool>aria handling) plus tests. DatabaseEntryRowredesigned: checkbox column, always-visible Remove button, slide-reveal CSS/state removed,FocusRemoveButtonAsyncexposed to parent.ManageDatabasesTabadds multi-select state, bulk strip, inline confirm via cascadedIInlineAlertSurface, dual-signal upgrade detection (Coordinator.IsUpgradeInFlight+ banner progress), cancel-then-remove withUpgradeBatchCompleted+UpgradeStateChangedTCS wait and 30s timeout, focus restoration with ImportButton fallback, and aria-live selection announcements.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/EventLogExpert.UI/Inputs/Checkbox.razor(.cs/.css) | New reusable checkbox component matching the Toggle pattern. |
| src/EventLogExpert.UI/Database/DatabaseEntryRow.razor(.cs/.css) | Row gains checkbox + always-visible Remove; slide-reveal removed; exposes FocusRemoveButtonAsync. |
| src/EventLogExpert.UI/DatabaseTools/Tabs/ManageDatabasesTab.razor(.cs/.css) | Multi-select, bulk strip, inline confirm, cancel-then-remove wait, focus restoration, live region. |
| tests/Unit/EventLogExpert.UI.Tests/Inputs/CheckboxTests.cs | Aria/value/disabled/icon coverage for new Checkbox. |
| tests/Unit/EventLogExpert.UI.Tests/Database/DatabaseEntryRowTests.cs | Updated to assert always-visible Remove, checkbox aria/state, selected class. |
| tests/Unit/EventLogExpert.UI.Tests/DatabaseTools/Tabs/ManageDatabasesTabTests.cs | Bulk accept/decline, dual-signal labels, baseline consume, strip visibility, live-region updates. |
| tests/Unit/EventLogExpert.UI.Tests/DatabaseTools/Tabs/FakeInlineAlertSurface.cs | Test fake recording inline alert requests with configurable result. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
76b40a7 to
25f9db8
Compare
c666275 to
a15956f
Compare
5a35925 to
e3ec101
Compare
…of clearing the entire set
… per-file removal failures
a15956f to
88c0b66
Compare
…onfirmation, and trimmed misleading test name
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database row UX redesign: replaces stop-gap Remove-during-upgrade behavior + extracts reusable Checkbox component. Closes #525.
Commits
Commit E (
5599a42d) — Remove flow redesign + multi-select (fully closes #525)Permanent redesign of Remove flow — replaces Commit B's aria-disabled+click-guard stop-gap on the per-row Remove button:
<div role=\"checkbox\" tabindex=\"0\">per-row multi-select with left-border accent for WCAG 1.4.11IInlineAlertSurface(single + bulk)Coordinator.UpgradeStateChangeddual signal + pre-Cancel recheck for gap-completion race + 30s timeout fallbackIsAnyFileUpgradinguses dual-signal (Coordinator.IsUpgradeInFlight(f) || GetUpgradeProgressForEntry(entry) is not null) so Background-scope/import-queued upgrades are also covered. Bulk anchor = MIN pre-removal index (deterministic). Bulk Remove callsConsumeReopenedAsBaseline()for parity.Commit F (
58eb8fa4) — Reusable Checkbox component + pending-ring removalExtracted per-row inline
<div role=\"checkbox\">into reusable<Checkbox>component atsrc/EventLogExpert.UI/Inputs/(matches Toggle convention: visually-hidden native<input type=\"checkbox\">in<label>with custom icon via CSS sibling combinator +:has()wrapper cursor). Removed pending blue box-shadow atDatabaseEntryRow.razor.css:203-205per user complaint. Massive simplification: dropped IAsyncDisposable, IJSRuntime, JS module,_jsModule,_checkboxRef,HandleCheckboxClick,HandleCheckboxKeyDownfrom DatabaseEntryRow (native input handles Space/Enter/preventDefault for free).Stack
This PR is the final of three stacked on top of #553. Order:
Tests