fix: tokenizer word_continuation case sensitivity for camelCase ident…#21
Merged
fix: tokenizer word_continuation case sensitivity for camelCase ident…#21
Conversation
…ifiers
The word_continuation method in StringWalker compared characters against
word_valid_chars (lowercase only) without normalizing case. This caused
camelCase identifiers starting with keywords (e.g., 'fromUser') to be
incorrectly tokenized as keyword + identifier ('FROM' + 'User').
Fix: normalize the next character to lowercase before checking.
Applied to both TypeScript and Python implementations.
Added tests for:
- Lookup with 'from' keyword as property name
- CamelCase alias starting with keyword ('fromUser')
- FROM keyword property in CREATE VIRTUAL subquery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ifiers
The word_continuation method in StringWalker compared characters against word_valid_chars (lowercase only) without normalizing case. This caused camelCase identifiers starting with keywords (e.g., 'fromUser') to be incorrectly tokenized as keyword + identifier ('FROM' + 'User').
Fix: normalize the next character to lowercase before checking. Applied to both TypeScript and Python implementations.
Added tests for: