This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Fix missing attributes for UILabel when set attributedText in iOS 11#102
Merged
levinli303 merged 2 commits intoMar 31, 2021
Merged
Conversation
Contributor
alex7vecher
commented
Mar 30, 2021
alex7vecher
commented
- Use addAttribute instead of setAttributes to avoid losing other attributes besides .foregroundColor.
- If the .foregroundColor attribute is not specified in the NSAttributedString, should be used UILabel textColor. This is standard behavior. Otherwise, the color of the UILabel text does not change.
levinli303
reviewed
Mar 31, 2021
Member
|
looks good, thanks for you contribution! |
levinli303
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.