Skip to content

cell.ts.applyStashedOp implementation#10776

Merged
dannimad merged 14 commits into
microsoft:mainfrom
dannimad:cellStashedOp
Jul 1, 2022
Merged

cell.ts.applyStashedOp implementation#10776
dannimad merged 14 commits into
microsoft:mainfrom
dannimad:cellStashedOp

Conversation

@dannimad
Copy link
Copy Markdown
Contributor

@dannimad dannimad commented Jun 21, 2022

cell.ts.applyStashedOp implementation

Board Item.

Reviewer Guidance

This is a first iteration to implement cell.ts.applyStashedOp. I still have the following doubts:
Not sure about type return object should always be edit or how to correctly determine the name of it { type: "edit", pendingMessageId: this.messageId };
What specifics tests should be added. I am thinking to add a SharedCell object to the stashedOps.spec.ts registry and add similar tests that are already in place for SharedMap but not sure if they should be added in the same it or a different one.

@github-actions github-actions Bot added area: dds Issues related to distributed data structures area: tests Tests to add, test infrastructure improvements, etc labels Jun 21, 2022
@dannimad dannimad requested a review from wes-carlson June 21, 2022 21:27
@github-actions github-actions Bot added the base: main PRs targeted against main branch label Jun 21, 2022
@github-actions github-actions Bot added the public api change Changes to a public API label Jun 21, 2022
wes-carlson
wes-carlson reviewed Jun 21, 2022
View reviewed changes
Comment thread packages/dds/cell/src/cell.ts Outdated
Comment thread packages/test/test-end-to-end-tests/src/test/stashedOps.spec.ts
@dannimad dannimad marked this pull request as ready for review June 22, 2022 18:59
@dannimad dannimad requested review from a team as code owners June 22, 2022 18:59
@dannimad dannimad requested a review from curtisman June 22, 2022 18:59
wes-carlson
wes-carlson reviewed Jun 23, 2022
View reviewed changes
Comment thread packages/dds/cell/src/cell.ts Outdated
Comment thread packages/test/test-end-to-end-tests/src/test/stashedOps.spec.ts Outdated
@dannimad
Copy link
Copy Markdown
Contributor Author

dannimad commented Jun 29, 2022

TODO: remove getPendingCellOps and make getPendingOps more generic

dannimad
dannimad commented Jun 30, 2022
View reviewed changes
Comment thread api-report/cell.api.md
wes-carlson
wes-carlson reviewed Jun 30, 2022
View reviewed changes
Comment thread api-report/cell.api.md
Comment thread packages/test/test-end-to-end-tests/src/test/stashedOps.spec.ts Outdated
Comment thread packages/dds/cell/src/cell.ts Outdated
wes-carlson
wes-carlson approved these changes Jun 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wes-carlson wes-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread api-report/cell.api.md Outdated
Comment thread packages/dds/cell/src/cell.ts Outdated
@dannimad dannimad merged commit 658f5b0 into microsoft:main Jul 1, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2022

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

@anthony-murphy anthony-murphy mentioned this pull request May 28, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curtisman curtisman Awaiting requested review from curtisman

1 more reviewer

@wes-carlson wes-carlson wes-carlson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: dds Issues related to distributed data structures area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch public api change Changes to a public API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dannimad @wes-carlson