[TaskManager] Fix assert error when sending a volunteer op before a complete op is acknowledged#12269
Merged
2 commits merged intoOct 7, 2022
Merged
Conversation
github-actions
Bot
added
area: dds
|
Hello @scottn12! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an assert error if
voulnteerForTask()is called before a pending complete op is acknowledged.Reviewer Guidance
Would you expect the behavior in this scenario to be different? Should we ignore the volunteer op in this scenario?
Any relevant logs or outputs
Before the change the newly added test would throw:
Other information or known dependencies
AB#2124